search

rstudio / DT

R Interface to the jQuery Plug-in DataTables
https://rstudio.github.io/DT/
Other
587 stars 184 forks source link

fix selection sync on client mode update (fixes #1125) #1126

Closed epruesse closed 3 months ago

epruesse commented 4 months ago

This is "minimally invasive". After the reload of the table on the client and potentially restoring selections via JS callback function, the cleanSelectedValues() function sends potentially incorrect <tbl>_xxx_selected information to R. The patch uses the functions already implemented to send row/col/cell selections made via Select extension to R. It simply triggers one update right then and there. Since the messages get merged, this effectively overwrites the false message created by cleanSelectedValues() exactly when the bug #1125 is triggered. It may not be a complete fix for other scenarios, but it is brief and has minimal chance of breaking things for other use cases.

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.