search

rstudio / DT

R Interface to the jQuery Plug-in DataTables
https://rstudio.github.io/DT/
Other
598 stars 181 forks source link

Upgrade DataTables to v1.13.11 #1141

Open stla opened 3 months ago

stla commented 3 months ago

Hello Yihui,

I wanted to do a PR to upgrade DataTables to v1.13.11 (the last 1.x version) but there are some problems.

The DataTables website provides a download builder for v1.13.11 but this download builder is not the same as before. You can select the files you want as before but then it only provides the links to these files, there's no longer a Download button:

datatablesDownload

Before, as I remember (not sure to correctly remember), there was a Download button and one got a zip containing some folders, e.g. one folder for each extension. I could manually put the extensions files in their respective folder, this is not a problem, but there is another problem. In addition to the extension files, this download builder only provides the links to dataTables.dataTables.min.css and jQuery.dataTables.min.js. However, before, there were more files in the zip, e.g. datatables.min.js and datatables.bootstrap5.min.js.

So I don't know how to proceed. Would you have an idea?

yihui commented 3 months ago

@stla Unfortunately, I'm insanely busy recently and don't have time to look into this. Previously, we have been using this script to upgrade DataTables: https://github.com/rstudio/DT/blob/main/tools/update_DT.R I'm not sure if it still works.

BTW, I have also transferred the maintenance of DT to Posit in April (c95609cc8ec55f80af399fd5a4b0a4849c012b69). I think it will be very unlikely that I'll be able to review your PR of upgrading the library this year. Thanks a lot for your interest and contributions anyway!

stla commented 2 months ago

Hi Yihui,

I can see you're insanely busy because you didn't carefully read my message, which is unusual. Your script still works in principle but the problem is that the download builder on the datatables website is now a legacy version and it has changed, so your script no longer applies to this download builder.