search

rstudio / blastula

Easily send great-looking HTML email messages from R
https://pkgs.rstudio.com/blastula
Other
547 stars 85 forks source link

Attached files in email are all named "Filename" because of a mislabeled function parameter inside mime.R #314

Closed jpd527 closed 1 year ago

jpd527 commented 1 year ago

https://github.com/rstudio/blastula/commit/0e1b1c705ea9a244105164aaae785d042c0a3ea7#r130328464

str = "Filename", needs to be changed to fieldname = "Filename", on line 104 of mime.R to fix the issue and properly label file attachments in the email.

chuxinyuan commented 1 year ago

same problem.

mvellinger commented 1 year ago

This is quite breaking, yes.

tylerlittlefield commented 1 year ago

For anyone that needs a quick fix, this is working for me on ubuntu:

remotes::install_version("blastula", "0.3.3")
b-rhodes commented 9 months ago

Would this be worth releasing as 0.3.5? Seems like a pretty impactful issue