Consider introducing dark mode for bs4_book-theme

rstudio / bookdown

Authoring Books and Technical Documents with R Markdown

https://pkgs.rstudio.com/bookdown/

GNU General Public License v3.0

3.71k stars 1.27k forks source link

Consider introducing dark mode for bs4_book-theme #1023

Open henningsway opened 3 years ago

henningsway commented 3 years ago

I like the new theme, but I mostly read bookdown books in the night mode. With the new theme this no longer seems possible and I miss it. :)

MattCowgill commented 3 years ago

I came here to say the same thing! The theme is nice, but really needs dark mode

PythonCoderUnicorn commented 2 years ago

I also wish to add to this issues.

2 issues I want to bring up:

I use Rmd and use a custom CSS file and after the pain in the butt experience of finding the exact HTML tag to edit for having a black or other non-white background for the < pre > and < code > it makes the < p > font so hard to size and edit. My current work around is to use '>' and paste the code so it has the background and font style. Also the use of `` `` of text will work when showing terminal output.
every R reference online book is white and every black mode toggle breaks when reading the webpage due to BlogDown / Rmd design. So far my work around is to open inspect elements and edit the background-color tag and the p,h1, etc tags but this works as long as I do not leave the page. Adding a toggle button to change basic elements should be added. If someone wants me to upload /submit a template for it I will . The all bright white background is too much to stare at.

debruine commented 2 years ago

Seconding this. I just had a student leave an issue on one of our course books, saying it's an accessibility issue.

PythonCoderUnicorn commented 2 years ago

Seconding this. I just had a student leave an issue on one of our course books, saying it's an accessibility issue.

last week I found a solution, thematic and bslib package to load a custom themed Rmd. Not much attention is paid to this as it was a 1 page . Here is a solution I got to work in Rmd

---
output: 
  html_document: 
    theme: 
      bg: "#002b36"
      fg: "#eee8d5"
      primary: "#2aa198"
---

# inside a code chunk
thematic::thematic_rmd()
library(bslib)

# i also use ggdark::dark_mode() for all my plots
library(ggdark)

for me tibbles don't work with color theme or maybe it's user error but the plots work out just fine.

fernandoroa commented 1 month ago

I think something like the following is a desirable related idea too, toggles:
https://changelog.gitbook.com/may-2023/30-may-a-light-dark-mode-toggle-and-new-customization-options https://squidfunk.github.io/mkdocs-material/setup/changing-the-colors/#color-palette-toggle