search

rstudio / bookdown

Authoring Books and Technical Documents with R Markdown
https://pkgs.rstudio.com/bookdown/
GNU General Public License v3.0
3.76k stars 1.27k forks source link

Fix extra_dependencies handling in gitbook() #1408

Closed ThierryO closed 1 year ago

ThierryO commented 1 year ago

The current implementation ignores extra_dependencies passed to gitbook().

ThierryO commented 1 year ago

Here is set of working examples with bookdown combined with another style . I use this collection of documents to test our corporate identity. Working on INBOmd is how I found this problem.

cderv commented 1 year ago

Awesome. Would that be ok to use this repo in our CI checks so that we can test if a new bookdown version is breaking something ? Or maybe you testing is enough ... 🤔

ThierryO commented 1 year ago

Sure. That's why we make them public with a open source license.