rstudio / bslib

Tools for theming Shiny and R Markdown via Bootstrap 3, 4, or 5.
https://rstudio.github.io/bslib/
Other
443 stars 50 forks source link

r-devel check issues requested by CRAN #1000

Closed cpsievert closed 3 months ago

cpsievert commented 4 months ago
Dear maintainer,

Please see the problems shown on
<https://cran.r-project.org/web/checks/check_results_bslib.html>.

Please correct before 2024-03-22 to safely retain your package on CRAN.

The CRAN Team
Check Details
Version: 0.6.1
Check: installed package size
Result: NOTE 
    installed size is 12.6Mb
    sub-directories of 1Mb or more:
      fonts   3.7Mb
      lib     5.4Mb
Flavors: [r-devel-linux-x86_64-fedora-clang](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/bslib-00check.html), [r-devel-windows-x86_64](https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/bslib-00check.html), [r-release-macos-arm64](https://www.r-project.org/nosvn/R.check/r-release-macos-arm64/bslib-00check.html), [r-release-macos-x86_64](https://www.r-project.org/nosvn/R.check/r-release-macos-x86_64/bslib-00check.html), [r-release-windows-x86_64](https://www.r-project.org/nosvn/R.check/r-release-windows-x86_64/bslib-00check.html), [r-oldrel-macos-arm64](https://www.r-project.org/nosvn/R.check/r-oldrel-macos-arm64/bslib-00check.html), [r-oldrel-windows-x86_64](https://www.r-project.org/nosvn/R.check/r-oldrel-windows-x86_64/bslib-00check.html)

Version: 0.6.1
Check: tests
Result: ERROR 
    Running ‘testthat.R’ [112s/59s]
  Running the tests in ‘tests/testthat.R’ failed.
  Complete output:
    > library(testthat)
    > library(bslib)

    Attaching package: 'bslib'

    The following object is masked from 'package:utils':

        page

    > 
    > test_check("bslib")
    Starting 2 test processes
    [ FAIL 3 | WARN 0 | SKIP 29 | PASS 466 ]

    ══ Skipped tests (29) ══════════════════════════════════════════════════════════
    • On CRAN (29): 'test-zzzz-bs-sass.R:4:3', 'test-zzzz-bs-sass.R:26:3',
      'test-zzzz-bs-sass.R:51:3', 'test-zzz-precompile.R:18:3',
      'test-bs-theme-preset-builtin.R:5:5', 'test-bs-theme-preset.R:7:5',
      'test-bs-theme-preset.R:14:5', 'test-bs-theme-preset.R:34:5',
      'test-fill.R:31:3', 'test-fill.R:48:3', 'test-fill.R:65:3',
      'test-fill.R:96:3', 'test-fill.R:115:3', 'test-fill.R:148:3',
      'test-fill.R:160:3', 'test-fill.R:191:3', 'test-fill.R:216:3',
      'test-fill.R:248:3', 'test-fill.R:261:3', 'test-fill.R:304:3',
      'test-layout.R:2:3', 'test-layout.R:50:3', 'test-layout.R:68:3',
      'test-layout.R:128:3', 'test-layout.R:134:3', 'test-page.R:68:3',
      'test-page.R:90:5', 'test-value-box.R:56:3', 'test-value-box.R:106:3'

    ══ Failed tests ════════════════════════════════════════════════════════════════
    ── Failure ('test-rmd-skeletons.R:17:3'): Rmd skeletons can be render cleanly ──
    `render_skeleton("legacy")` threw an unexpected error.
    Message: pandoc document conversion failed with error 1
    Class:   simpleError/error/condition
    Backtrace:
         ▆
      1. ├─testthat::expect_error(render_skeleton("legacy"), NA) at test-rmd-skeletons.R:17:3
      2. │ └─testthat:::expect_condition_matching(...)
      3. │   └─testthat:::quasi_capture(...)
      4. │     ├─testthat (local) .capture(...)
      5. │     │ └─base::withCallingHandlers(...)
      6. │     └─rlang::eval_bare(quo_get_expr(.quo), quo_get_env(.quo))
      7. └─bslib (local) render_skeleton("legacy")
      8.   └─rmarkdown::render(file.path(tmp, "tmp.Rmd"), quiet = TRUE) at test-rmd-skeletons.R:9:3
      9.     └─rmarkdown (local) convert(output_file, run_citeproc)
     10.       └─rmarkdown (local) convert_it(output)
     11.         └─rmarkdown (local) convert_fun(...)
     12.           └─rmarkdown:::stop2(...)
    ── Failure ('test-rmd-skeletons.R:18:3'): Rmd skeletons can be render cleanly ──
    `render_skeleton("new")` threw an unexpected error.
    Message: pandoc document conversion failed with error 1
    Class:   simpleError/error/condition
    Backtrace:
         ▆
      1. ├─testthat::expect_error(render_skeleton("new"), NA) at test-rmd-skeletons.R:18:3
      2. │ └─testthat:::expect_condition_matching(...)
      3. │   └─testthat:::quasi_capture(...)
      4. │     ├─testthat (local) .capture(...)
      5. │     │ └─base::withCallingHandlers(...)
      6. │     └─rlang::eval_bare(quo_get_expr(.quo), quo_get_env(.quo))
      7. └─bslib (local) render_skeleton("new")
      8.   └─rmarkdown::render(file.path(tmp, "tmp.Rmd"), quiet = TRUE) at test-rmd-skeletons.R:9:3
      9.     └─rmarkdown (local) convert(output_file, run_citeproc)
     10.       └─rmarkdown (local) convert_it(output)
     11.         └─rmarkdown (local) convert_fun(...)
     12.           └─rmarkdown:::stop2(...)
    ── Failure ('test-rmd-skeletons.R:19:3'): Rmd skeletons can be render cleanly ──
    `render_skeleton("real-time")` threw an unexpected error.
    Message: pandoc document conversion failed with error 1
    Class:   simpleError/error/condition
    Backtrace:
         ▆
      1. ├─withr::with_namespace(...) at test-rmd-skeletons.R:19:3
      2. │ └─base::force(code)
      3. ├─testthat::expect_error(render_skeleton("real-time"), NA)
      4. │ └─testthat:::expect_condition_matching(...)
      5. │   └─testthat:::quasi_capture(...)
      6. │     ├─testthat (local) .capture(...)
      7. │     │ └─base::withCallingHandlers(...)
      8. │     └─rlang::eval_bare(quo_get_expr(.quo), quo_get_env(.quo))
      9. └─bslib (local) render_skeleton("real-time")
     10.   └─rmarkdown::render(file.path(tmp, "tmp.Rmd"), quiet = TRUE) at test-rmd-skeletons.R:9:3
     11.     └─rmarkdown (local) convert(output_file, run_citeproc)
     12.       └─rmarkdown (local) convert_it(output)
     13.         └─rmarkdown (local) convert_fun(...)
     14.           └─rmarkdown:::stop2(...)

    [ FAIL 3 | WARN 0 | SKIP 29 | PASS 466 ]
    Deleting unused snapshots:
    • page/card.html
    • page/modern-page.html
    • zzzz-bs-sass/bs4-imports
    • zzzz-bs-sass/bs5-imports
    Error: Test failures
    Execution halted
Flavor: [r-devel-linux-x86_64-fedora-clang](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/bslib-00check.html)
cpsievert commented 4 months ago

This is actually a real issue that should be addressed in {sass} (https://github.com/rstudio/sass/issues/138)

1001 "fixed" this by skipping on CRAN, but we don't necessarily need to do that.

github-actions[bot] commented 1 month ago

This issue has been automatically locked. If you have found a related problem, please open a new issue (with a reproducible example or feature request) and link to this issue. :raising_hand: Need help? Connect with us on Discord or Posit Community.