rstudio / bslib

Tools for theming Shiny and R Markdown via Bootstrap 3, 4, or 5.
https://rstudio.github.io/bslib/
Other
443 stars 49 forks source link

chiflights22 is not a CRAN package #1046

Closed JosiahParry closed 2 months ago

JosiahParry commented 2 months ago

This app is not reproducible without being able to sleuth around the internet very well. It seems chiflights is a passion project from @cpsievert (perhaps made specifically for this example!) and is not published on CRAN. Figuring out how to install this package was a bit of work that some people less familiar with R might not know how to do.

https://github.com/rstudio/bslib/blob/5046bbd4aadfc758903290fed0584bb8711ef13a/inst/examples/flights/app.R#L6

gadenbuie commented 2 months ago

That's right, it's made with the anyflights package, which expressly recommends not sending a derivative package to CRAN.

We should definitely include at least a note in a comment in the source, I've also run into a 🤔 moment trying to remember where the package lives.

For the record, it's recorded here in bslib's DESCRIPTION file

https://github.com/rstudio/bslib/blob/5046bbd4aadfc758903290fed0584bb8711ef13a/DESCRIPTION#L64

JosiahParry commented 2 months ago

now that is what i call a description file! holy smokes!

github-actions[bot] commented 6 days ago

This issue has been automatically locked. If you have found a related problem, please open a new issue (with a reproducible example or feature request) and link to this issue. :raising_hand: Need help? Connect with us on Discord or Posit Community.