{bsicons} should be imported rather than suggested

rstudio / bslib

Tools for theming Shiny and R Markdown via Bootstrap 3, 4, or 5.

https://rstudio.github.io/bslib/

Other

472 stars 57 forks source link

{bsicons} should be imported rather than suggested #1063

Closed daattali closed 2 months ago

daattali commented 4 months ago

I just tried running bs_theme_preview() and got an error because {bsicons} wasn't installed. I then did a search through {bslib}'s codebase and I see that there are other uses of {bsicons} so it would probably be a good idea to make it an import

gadenbuie commented 2 months ago

Thanks @daattali, it'd be reasonable for bslib to depend directly on bsicons, but we have to balance bslib's dependencies with the fact that bslib is in turn a direct dependency of shiny and rmarkdown.

I looked through the codebase and bs_theme_preview() is the only place where we directly call bsicons, in all other places we're careful to use bsicons as a progressive enhancement. I think it's reasonable that bsicons remain a suggested dependency for now.

github-actions[bot] commented 2 weeks ago

This issue has been automatically locked. If you have found a related problem, please open a new issue (with a reproducible example or feature request) and link to this issue. :raising_hand: Need help? Connect with us on Discord or Posit Community.