rstudio / bslib

Tools for theming Shiny and R Markdown via Bootstrap 3, 4, or 5.
https://rstudio.github.io/bslib/
Other
490 stars 58 forks source link

Remove call to `shiny::useBusyIndicators()` #1092

Closed cpsievert closed 4 months ago

cpsievert commented 4 months ago

Follow up to #1053

Update: After some discussion, we're now going to enable busy indicators by default in Shiny itself (https://github.com/rstudio/shiny/pull/4104), so this PR just removes the call to shiny::useBusyIndicators()

~Before this change, busy indicators were only getting enabled by default for bslib::page(). After this change, any bslib-powered UI will get shiny::useBusyIndicators() by default.~

cpsievert commented 4 months ago

Oh wait, I'll just update this PR to not call useBusyIndicators() (in light of https://github.com/rstudio/bslib/pull/1092#discussion_r1690032818)