search

rstudio / bslib

Tools for theming Shiny and R Markdown via Bootstrap 3, 4, or 5.
https://rstudio.github.io/bslib/
Other
490 stars 58 forks source link

UI page functions don't know how to deal with extra commas like {shiny} does #1097

Closed daattali closed 4 months ago

daattali commented 4 months ago

In the olden days, shiny apps would break if there was any extra comma in the UI. This was fixed a few years ago and now the following app works: 

library(shiny)

ui <- fluidPage(
  "foo",
)

server <- function(input, output, session) {}

shinyApp(ui, server)

But when I try the same using {bslib}, I get an error:

library(shiny)

ui <- bslib::page_fluid(
    "foo",
)

server <- function(input, output, session) {}

shinyApp(ui, server)
Error in `dots_list()`:
! Argument 3 can't be empty.
daattali commented 4 months ago

AFAICT this ws described but not fixed in https://github.com/rstudio/bslib/issues/956

gadenbuie commented 4 months ago

I just fixed this in https://github.com/rstudio/bslib/pull/1095. It made it into the 0.8.0 release that landed on CRAN this week. Let us know if you're still seeing the issue after updating.

daattali commented 4 months ago

Fixed indeed!

github-actions[bot] commented 2 months ago

This issue has been automatically locked. If you have found a related problem, please open a new issue (with a reproducible example or feature request) and link to this issue. :raising_hand: Need help? Connect with us on Discord or Posit Community.