search

rstudio / bslib

Tools for theming Shiny and R Markdown via Bootstrap 3, 4, or 5.
https://rstudio.github.io/bslib/
Other
466 stars 57 forks source link

bootstrap 3: Dotted border lines shown around html components (navs, tables, panels etc) #232

Closed MadhulikaTanuboddi closed 3 years ago

MadhulikaTanuboddi commented 3 years ago

Check the snapshots below

When testing the themer-demo app with bootstrap version3, I noticed some border lines(dotted) around some of the html components especially when using all the bootswatch themes (listed in the real time themer). In order to see the these dotted borders, make sure to have the focus on the page (In other words, click somewhere on the page). Also, note that this does not happen with bootstrap version4

@cpsievert mentioned that this could be expected to support accessibility for navigation. Just adding this issue for tracking and probably more details needed on how we want to work regarding the same with bootstrap version 4 or future versions.

bs3_borderline-containers Screen Shot 2021-01-12 at 12 25 17 PM Screen Shot 2021-01-12 at 12 06 25 PM

Additional context: Initially, this issue was noticed on Jan 12. I am testing this fix (https://github.com/rstudio/bslib/pull/224) today using remotes::install_github("rstudio/bslib@rc-v0.2.4") and its not resolved yet.

cpsievert commented 3 years ago

Ah, crap, this was the point of #224, but I didn't roll that into rc-v0.2.4 correctly 🤦

cpsievert commented 3 years ago

@MadhulikaTanuboddi I was able to get the fix for this into the CRAN version of bslib. Feel free to verify with

install.packages("bslib")
github-actions[bot] commented 1 year ago

This issue has been automatically locked. If you have found a related problem, please open a new issue (with a reproducible example or feature request) and link to this issue. :raising_hand: Need help? Connect with us on Discord or Posit Community.