rstudio / bslib

Tools for theming Shiny and R Markdown via Bootstrap 3, 4, or 5.
https://rstudio.github.io/bslib/
Other
491 stars 58 forks source link

Bootswatch 4 litera file upload alignment #277

Open stefanoborini opened 3 years ago

stefanoborini commented 3 years ago

Shiny 1.6.0 generates bs3 classes. If I use theme = bslib::bs_theme(bootswatch = "litera") it will use the css for bootstrap 4, but shiny generates bs3 classes so they apply poorly. Adding theme = bslib::bs_theme(version = 3, bootswatch = "litera") gives an error message of the theme not being available.

cpsievert commented 3 years ago

Shiny 1.6.0 generates bs3 classes. If I use theme = bslib::bs_theme(bootswatch = "litera") it will use the css for bootstrap 4, but shiny generates bs3 classes so they apply poorly.

The HTML/CSS that Shiny generates should be supported by bslib's custom version of BS4 -- could you please provide specific example(s)?

Adding theme = bslib::bs_theme(version = 3, bootswatch = "litera") gives an error message of the theme not being available.

The Bootswatch 3 version of litera is called readable https://bootswatch.com/3/readable/

stefanoborini commented 3 years ago

the file upload dialog generated looks nothing like the one in bootswatch, and it's poorly aligned.

cpsievert commented 3 years ago

Ah yea the alignment should be fixed

Screen Shot 2021-02-22 at 10 08 28 AM

FWIW, the styling looks different because shiny intentionally adds input-group classes whereas the example on the Bootswatch site doesn't