search

rstudio / bslib

Tools for theming Shiny and R Markdown via Bootstrap 3, 4, or 5.
https://rstudio.github.io/bslib/
Other
486 stars 58 forks source link

Theme customizer not working #74

Closed jokroese closed 4 years ago

jokroese commented 4 years ago

Summary

Theme customizer is not responding to clicks on menu items other than 'Background color' and 'Foreground color'.

Details

'Background color' and 'Foreground color' work as expected, changing the values and printing the changed code to the console. However, clicking on any of the other items in the Theme customizer does not work. These items do not expand their view and so you cannot change the value of the parameters.

bootstraplib-theme-customizer-error-demonstration

Opening it in the browser gives the same issues.

Reproduce

On Mac Catalina 10.15.4, R 4.0.0, RStudio 1.3.959, run: 

bootstraplib::bs_theme_new(bootswatch = "sketchy")
bootstraplib::bs_theme_preview()

Clicking on any of the options ('Accent colors', 'Fonts' etc.) will not change the view.

cpsievert commented 4 years ago

Woah, this is very surprising! After you change the background or foreground, could you please open your browsers developer tools (i.e., Right-click -> Inspect Element -> Console Tab) and report any errors that you see? Also what browsers have you tried?

cpsievert commented 4 years ago

Oh actually, I can reproduce, here's the error

Screen Shot 2020-06-23 at 11 04 45 AM
cpsievert commented 4 years ago

I believe this issue was recently fixed, please re-open if you encounter any issues @joekroese

jokroese commented 4 years ago

I can confirm the fix - it works for me now :) Thanks for letting me know. I'm looking forward to using this package for my next shiny project!

github-actions[bot] commented 1 year ago

This issue has been automatically locked. If you have found a related problem, please open a new issue (with a reproducible example or feature request) and link to this issue. :raising_hand: Need help? Connect with us on Discord or Posit Community.