Open gsmolinski opened 10 months ago
Thanks for the report! It seems like, if we take on any changes, they'll be in bslib, so I'll be transferring there.
Also, could you elaborate a bit on why you need min_height = "100vh"
? Is it to keep the card full height on mobile? In that case, I'd recommend doing page_fillable(fillable_mobile = TRUE)
instead
Thank you! I'm not sure I will be able to answer your question, because I have a one dashboard I made using first time bslib and everything was like "ok, I'm not sure how this works, but let's try this and this and see how it looks when I make browser smaller and bigger" (actually, not for a mobile, but for a 14-27 inch displays).
However, I have a different example when footer is hide, now without min_height
, but with tabset
, maybe this will be helpful:
library(shiny)
library(bslib)
ui <- page_navbar(
nav_panel("One",
tabsetPanel(
tabPanel(title = "tab",
card(
card_body(
DT::dataTableOutput("tbl_1")
)
),
card(
card_body(
DT::dataTableOutput("tbl_2")
)
)
)
)
),
footer = tags$p("TEST")
)
server <- function(input, output, session) {
output$tbl_1 <- DT::renderDataTable(
iris
)
output$tbl_2 <- DT::renderDataTable(
iris
)
}
shinyApp(ui, server)
Code:
Problem: Footer (with the "TEST" string) is hide by card, in the previous
htmltools
version, it was stick on the bottom of webpage.Info: