rstudio / bslib

Tools for theming Shiny and R Markdown via Bootstrap 3, 4, or 5.
https://rstudio.github.io/bslib/
Other
475 stars 57 forks source link

fix: Move mobile always-open CSS below collapsible mobile rules #982

Closed gadenbuie closed 7 months ago

gadenbuie commented 7 months ago

This PR fixes the top border of the sidebar when open = list(mobile = "always") and position = "right".

There's a border: none that was unintentionally being applied in this case. When position = "right" the rule to add the border-top and the rule to remove the border have the same specificity and the second rule wins because it's later in sidebar.scss. I resolved the specificity battle by moving the always-open-on-mobile rules to the end of the file (where they arguably should have been in the first place).