search

rstudio / bslib

Tools for theming Shiny and R Markdown via Bootstrap 3, 4, or 5.
https://rstudio.github.io/bslib/
Other
443 stars 50 forks source link

Fix downloading Google Fonts #983

Closed gadenbuie closed 5 months ago

gadenbuie commented 5 months ago

Apparently Google Fonts started using font URLs where the font ID is stored in a query string, e.g.

https://fonts.gstatic.com/l/font?kit=JTUHjIg1_i6t8kCHKm4532VJOt5-QNFgpCtZ6Ew9&skey=7bc19f711c0de8f&v=v26

This update pulls out the kit value from the URL and uses it as the font id, which seems to be consistent with the previous format, which looked like this

https://fonts.gstatic.com/s/montserrat/v26/JTUHjIg1_i6t8kCHKm4532VJOt5-QNFgpCuM70w9.woff

*Note: I haven't been able to find anything online documenting this change.

gadenbuie commented 5 months ago

Merging ahead of review to unblock other PRs. @cpsievert Let me know if you see anything off and I'll follow up.