search

rstudio / bundle

Prepare objects for serialization with a consistent interface
https://rstudio.github.io/bundle/
Other
27 stars 4 forks source link

update testing strategy #45

Closed simonpcouch closed 2 years ago

simonpcouch commented 2 years ago

Details on implementation in the new tests/testthat/README.md! Loooots of additions/deletions here, but all based on copy/pasting the template from there.

Closes #40. :)

simonpcouch commented 2 years ago

Heading out for OOO through the 8th, but don't quite have time to debug some issues with h2o server connections within those callr subprocesses. Could I hand this off to you, @juliasilge? I otherwise feel good about this approach, so should be ready for review from my perspective!🏄

juliasilge commented 2 years ago

For h2o, we are running into the same problem that agua ran into in dealing with the h2o server in tests. We see this exact error.

For the time being, we'll try only running these h2o tests interactively. 🤷‍♀️ This is the same approach that agua is taking.