rstudio / chromote

Chrome Remote Interface for R
https://rstudio.github.io/chromote/
156 stars 20 forks source link

Allow enable() and disable() methods to be used when auto_events is TRUE #156

Open ashbythorpe opened 6 months ago

ashbythorpe commented 6 months ago

Fixes #144.

Works by keeping track of which domains have been manually enabled, and does not call enable() in inc_event_callback_count() or disable() in dec_event_callback_count() until the corresponding disable() method is called.

If the event callback number is more than 0, and disable() is called, automatic event handling is disabled until the callback count reaches 0 (not by design, just due to how the callback count functions were written in the first place).

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.