rstudio / connectwidgets

The {connectwidgets} package allows you to curate your content on RStudio Connect, helping to create organized groups of content within an RMarkdown document or Shiny app.
https://rstudio.github.io/connectwidgets/
Other
21 stars 7 forks source link

Changes for upcoming htmlwidgets 1.6 release #79

Closed cpsievert closed 1 year ago

cpsievert commented 1 year ago

The upcoming htmlwidgets 1.6 release happens to break the unit tests that check the class of htmlwidgets::shinyWidgetOutput() (the new release will add some additional classes). Updating those expectations to use expect_match() instead of expect_equal() will get them passing with the new release.

Also, with htmlwidgets 1.6, rsc*Output() now throws a warning because they return a tagList() (which won't work for the new fill parameters). And since it seems like you don't need to use tagList() here and can instead just include the extra dependencies in the <div>, I made that change as well