rstudio / dbtest

Automates testing of vector expressions of SQL translations for dplyr
http://db.rstudio.com/translation
Other
11 stars 5 forks source link

Pkg documentation #12

Closed colearendt closed 6 years ago

colearendt commented 6 years ago

Heavy review of package documentation and some minor implementation changes:

this gets us very close to 0.1.0. Still a handful of things to wrestle through, but wanted to get your feedback on progress thus far!

You will notice I began breaking out the tests I am writing into multiple files. I think this follows testthat best practices and will make managing the tests easier in the long term. One note worth considering - the tests get very verbose with all of the verbs represented. However, I do not think there is a nice way to run the same logic through multiple verbs without getting really complicated, so I agree with your decision thus far to keep the verbosity in the interest of clarity.