rstudio / dygraphs

R interface to dygraphs
http://rstudio.github.io/dygraphs
Other
365 stars 194 forks source link

Feature request: update to dygraph.js v2.0.0 #241

Open AllanCameron opened 4 years ago

AllanCameron commented 4 years ago

After trying unsuccessfully to solve this issue on Stack Overflow, I realised it would only be possible to add custom legend formatting by upgrading the underlying dygraphs.js library to v2.0.0. Although I forked the project and got it working quite quickly with dygraph v2.0.0, there were lots of bugs caused by the change in interface between v1 and v2. Are there any plans to upgrade the R dygraphs package to the latest version of dygraph.js (which is already 2 years old)? Are there concerns about back-compatability or is it not worth the development time?

sje-c commented 4 years ago

On a very related note. I've found that upgrading from R 3.4.4 to R 4.0.0 and the related packages required for javascript processing, broke my custom valueFormatter and axisLabelFormatter javascript functions for dygraphs (1.1.1.6). Initially I thought the problem was the upgrade in V8 as I was using the literal JS() prior to the input to the dyAxis adjustments. However it was actually the HtmlWidgets going from 1.3 to 1.5.1 that screwed my custom legend formatting up.

Without rolling back HtmlWidgets even some old examples that people have posted just didn't even show the graph in an R Studio interactive session: https://stackoverflow.com/questions/28486510/how-to-format-dygraphs-labels-in-r-comma-separate-thousands-place

What's the etiquette on finding out the state of a package? Contributors move on, which is fair enough.

@AllanCameron I'm interested in a dygraphs v2.0.0 update as well. I'm wondering if everybody is moving to plotly and c3 now.

GitHunter0 commented 2 years ago

Hi folks, @jjallaire @przmv , any news in this regard?