search

rstudio / fontawesome

Easily insert FontAwesome icons into R Markdown docs and Shiny apps
https://rstudio.github.io/fontawesome/
Other
296 stars 39 forks source link

fa() should return a htmltools::tag() object #58

Open cpsievert opened 3 years ago

cpsievert commented 3 years ago

Using tag() over HTML() is would make the return value more customizable and more consistent with the return value of fa_i()

sanjmeh commented 1 year ago

Is this the reason the following code does not (still) work?

 menuItem(text = "Truck Monster",icon = fa(name = "truck-monster",height = "30px"))
sanjmeh commented 1 year ago

I keep getting the followng error unless I remove all icon = fa(..) from my menuItem(...) lines.

Warning: Error in tagAssert: Expected an object with class 'shiny.tag'.