search

rstudio / fuzzbucket

a simplified means to CRUD ephemeral user-scoped EC2 instances
MIT License
7 stars 2 forks source link

Resize/renumber the default VPC CidrBlocks #138

Closed statik closed 6 months ago

statik commented 6 months ago

Fixes #137

Also avoid 172.17.0.0/16 block used by AWS Cloud9 and SageMaker per https://docs.aws.amazon.com/vpc/latest/userguide/vpc-cidr-blocks.html

I think to pick up this change folks might need to tear down/redeploy their fuzzbucket deployment?

statik commented 6 months ago

@meatballhat thank you! should I do a separate PR to try and get the lint checks passing or do it in this branch?

statik commented 6 months ago

FWIW hatch run lint is passing cleanly locally 🤔

statik commented 6 months ago

hatch run test also passes locally, I would love to merge this so we can deal with the existing CI failure separately.

statik commented 6 months ago

apparently not having black installed results in hatch run lint passing locally 😄 once I installed black, I was able to reproduce the formatting changes.

statik commented 6 months ago

@meatballhat thanks for all the help!