rstudio / ggvis

Interactive grammar of graphics for R
Other
713 stars 171 forks source link

Default mark_area is upside down #86

Open hadley opened 10 years ago

hadley commented 10 years ago
df <- data.frame(x = 1:10, y = runif(10))
df %>% ggvis(~x, ~y) %>% layer_ribbons()
wch commented 10 years ago

I think that y2 needs to be listed as a required prop for ribbon/area:

df <- data.frame(x = 1:10, y = runif(10))
df %>% ggvis(~x, ~y, y2=0) %>% layer_ribbons()
hadley commented 10 years ago

It should be required for ribbon, but it shouldn't be needed for area.

wch commented 10 years ago

We'll need to re-think where we do props checking and applying the defaults in general.