search

rstudio / helm

Helm Resources for RStudio Products
MIT License
36 stars 28 forks source link

Add imagePullSecret to prepull-daemonset #157

Open colearendt opened 2 years ago

colearendt commented 2 years ago

Not necessarily in this PR, but I think some customers will need to set an imagePullSecrets here from an optional {{ .imagePullSecret }} in the config

_Originally posted by @dbkegley in https://github.com/rstudio/helm/pull/154#discussion_r810247063_

LincStoel commented 12 months ago

Unrelated to the initial request, but still asking for the same feature I was able to get some context for how this impacts a workflow and thought i'd add it here. This was from Jason Stell and Kranthi Kancharla at the Cincinnati Reds.

I asked what the impact of not having this feature is on their workflow and received this in response:

"The docker images that we use for workbench and our build agents are quite large so when we have updates to them the initial pull to each of our kubernetes nodes takes a while and sometimes even times out a workbench session waiting on the pull. So it’d be nice to have this automated way to pre pull the large docker images."

I followed up asking if they could provide a rough time estimate of the burden that this was on their team and received this:

"Currently our pipelines are taking on an average 1 hour 30 minutes to do docker build for couple images and for couple other images are taking more than 2 hours, so we would like to reduce the time ASAP."

Additionally, here is the initial support ticket that they opened before contacting me directly.