search

rstudio / helm

Helm Resources for RStudio Products
MIT License
33 stars 28 forks source link

add option to set subdir on the PVC volume mount #404

Closed colearendt closed 1 year ago

colearendt commented 1 year ago

One thing that needs to be vetted: Does Launcher / the job launching process handle this subdir properly (and subdir below it?)... or will we need to pass this sub-directory along somehow?

Also need to:

colearendt commented 1 year ago

Tested a bit and things look good!

dbkegley commented 11 months ago

One thing that needs to be vetted: Does Launcher / the job launching process handle this subdir properly (and subdir below it?)... or will we need to pass this sub-directory along somehow?

When off-host is enabled for Connect, I don't think this setting will play nicely with Launcher.DataDirPVCName, which will not allow setting a subpath currently. Using this new setting with off-host enabled will likely cause the content datadir to be misaligned

"volumes": [
    {
      "name": "mount0",
      "persistentVolumeClaim": {
        "claimName": "connect-pvc"
      }
    },
...
],
"volumeMounts": [
    {
      "mountPath": "/opt/rstudio-connect/mnt/app",
      "name": "mount0",
      "subPath": "apps/1/1"
    },
...
  ]

In the above example, I think apps/1/1 should really be: <sharedStorage.subPath>/apps/1/1