search

rstudio / helm

Helm Resources for RStudio Products
MIT License
33 stars 28 forks source link

[rstudio-connect] wrong type for var #409

Open Almenon opened 1 year ago

Almenon commented 1 year ago

.Values.sharedStorage.storageClassName has the type bool and default false.

https://github.com/rstudio/helm/blob/666e86da88124a40e823a9e23925702d151b8076/charts/rstudio-connect/README.md?plain=1#L178

However, it's passed to the PersistentVolumeClaim kind, spec.storageClassName, which is a string.

https://github.com/rstudio/helm/blob/666e86da88124a40e823a9e23925702d151b8076/charts/rstudio-connect/templates/pvc.yaml#L14C3-L14C19

I haven't tested it, but based on the API reference this is probably a bug.

bschwedler commented 1 year ago

Thank you for reporting this!

It looks like we also have a couple of other variables that we need to update for the correct type.

Setting up a JSON schema as in #35 should help us catch & document these in a more automated fashion.

colearendt commented 1 year ago

Also worth noting that "mutable types" are kinda a weird / hard thing in helm.

While we do false as a proxy for "not set" currently in a handful of places (and we should not), there are also some places where we allow either a {} or a string, for instance. Helm is not a fan of this, so we will need to do some exploration on those items.

Almenon commented 11 months ago

Looks like same issue with package manager FYI