rstudio / helm

Helm Resources for RStudio Products
MIT License
36 stars 28 forks source link

Remove CRAN override from Connect chart value #417

Closed fh-mthomson closed 1 year ago

fh-mthomson commented 1 year ago

Motivation: If a user specifies a non-PPM version of CRAN (e.g., https://cran.r-project.org/) when deploying to Connect, the current Helm chart overrides it with the PPM version of CRAN, which may not yet have the latest version of a package.

This change (1) removes this constraint (while still having RSPM pointing to PPM as a fall back) and (2) mirrors the workbench Helm chart (changed here)

dbkegley commented 1 year ago

Connect v2023.09 has some modifications to the default PackageURL behavior.

Connect has new strategies for resolving the set of R package repositories used to install packages in content environments, and controlling how configured RPackageRepository entries and content repositories are used. These are controlled with the setting R.PackageRepositoryResolution. The default behavior has changed. The new default, lax, uses a combined list of configured repositories and repositories from content. To use only configured repositories and discard content repositories, set to strict. To use the old overriding behavior, set to legacy. See the Admin Guide for more details and examples. (#23853)

Does the new default behavior make this change unnecessary?

cc @toph-allen

fh-mthomson commented 1 year ago

Brilliant! lax is exactly what I think would solve this. Much appreciated!

For more context, see https://support.posit.co/hc/en-us/requests/91166 where we'd previously discussed.