search

rstudio / helm

Helm Resources for RStudio Products
MIT License
33 stars 28 forks source link

Issue with semicolons in Postgres passwords for Connect and Package Manager #420

Open tnederlof opened 11 months ago

tnederlof commented 11 months ago

When there is a semicolon in the password for Connect or Package Manager (either passed in via --set in helm or in the values file), the services fail to connect to the Postgres database. Taking out the semicolon (and changing the password on the Postgres side) then works without issue.

I think its an issue in translating the values to the config files. If I run Connect and Package Manager outside of k8s and put the password with a semicolon in the configs, it works without issue.

colearendt commented 11 months ago

This is probably because we do not quote the generated config:

[Postgres]
Password = somevalue;withtext

Semi-colons are comments in gcfg, so quoting the value would likely fix. We can add that to our generation.

Alternatively, we could start using env vars for password, which is probably preferable from a secret management point of view!

Workarounds in the short term are to set env var manually yourself, or encrypt the value with rskey