search

rstudio / helm

Helm Resources for RStudio Products
MIT License
33 stars 28 forks source link

Resolve issue so subPath: true works correctly #429

Closed tnederlof closed 10 months ago

tnederlof commented 10 months ago

This PR sets mountPath to license.file.mountPath/license.file.secretKey when mountSubPath: true. This is the correct syntax when using subPath.

Closes: https://github.com/rstudio/helm/issues/427

Also bumps each product to use the new rstudio-library

CLAassistant commented 10 months ago

CLA assistant check
All committers have signed the CLA.

tnederlof commented 10 months ago

This LGTM but should probably be tested manually if possible.

I was able to manually test it with Workbench, mounted correctly (was broken before). Also checked the pod YAML to see the mount path which matched what I expected.

tnederlof commented 10 months ago

@atheriel ended up bumping the products here