Closed AlexMapley closed 6 months ago
@shahmonanshi @tnederlof @colearendt I'm not who sure who the go to for the approval on this PR will be, but I was hoping some of you could take a look and give the okay on these changes. Thank you in advance!
I was thinking we don't need to bump up the chart versions if we're not including any changes to our actual templates in this branch.
@AlexMapley sorry, I don't know much with regards to the CI, @colearendt will likely know more there.
No worries @tnederlof, ty for taking a look anyways. With https://github.com/rstudio/helm/pull/457 we can probably close this branch too soon
Background
Closes https://github.com/rstudio/helm/issues/445
Summary
complex-values.yaml
test files with the chronicle-agent and a busybox sidecar, which will run in our cighcr.io/rstudio/chronicle-agent:2023.10.4
, the last agent releaseNotes
We are currently failing 1 ci job: https://github.com/rstudio/helm/actions/runs/7132419728/job/19422921712, complaining that we haven't bumped up the chart version in this PR. We haven't changed the contents of these charts though, just the docs and ci. Bumping up the chart version is unwarranted, so I'm going to ignore this complaint.
This is coming from https://github.com/rstudio/helm/blob/main/.github/workflows/chart-test.yaml#L33, and I don't think
ct list-changes
is flexible enough to ignore.md
or.ci
file changes:hence why i'd rather just ignore this for now - I don't have a good fix in mind.