rstudio / helm

Helm Resources for RStudio Products
MIT License
36 stars 28 forks source link

PPM - set default for `config.Server.RVersion` and `config.Server.PythonVersion` to `""` #474

Closed SamEdwardes closed 8 months ago

SamEdwardes commented 8 months ago

Description

Update the default values config.Server.RVersion and config.Server.PythonVersion to""`. This will ensure that Package Manager uses R and Python autodetection unless the user explicitly sets the desired R or Python version in the Helm chart.

Related

Testing

I did a test deployment of the changes. I confirmed that autodetection kicked in as expected:

2024/03/01 22:34:21 Checking for newly supported operating systems and R versions
2024/03/01 22:34:21 Updated supported operating systems and R versions to latest
2024/03/01 22:34:21 Info: User namespace sandbox test successful.
2024/03/01 22:34:21 `Server.RVersion` was not set. Attempting to auto-detect.
2024/03/01 22:34:22 R 4.2.3 auto-detected on the system successfully at /opt/R/4.2.3/bin/R. To set the version manually configure the `Server.RVersion` option.
2024/03/01 22:34:22 `Server.PythonVersion` was not set. Attempting to auto-detect.
2024/03/01 22:34:22 Python 3.10.12 auto-detected on the system successfully at /usr/bin/python3. To set the version manually configure the `Server.PythonVersion` option.
2024/03/01 22:34:22 Warning: Unable to build Git packages for Python on this system: required Python modules `build`, `virtualenv` are not installed
2024/03/01 22:34:22 Posit Package Manager service is ready
tylfin commented 8 months ago

FYI we have a fix for this in the upcoming release:

Warning: Unable to build Git packages for Python on this system: required Python modules build, virtualenv are not installed

https://github.com/rstudio/package-manager/pull/13097

SamEdwardes commented 8 months ago

@tnederlof thank you for the review. I made the suggested changes. Regarding what config options to document I removed R and Python from the config since we can rely on the product's default behaviour.