search

rstudio / helm

Helm Resources for RStudio Products
MIT License
32 stars 28 forks source link

Update README link for Connect config #476

Closed annikakrilov closed 5 months ago

annikakrilov commented 5 months ago

Fixes #475

"Under the Values -> Config section, the README currently points towards https://docs.posit.co/connect/admin/appendix/configuration/ which doesn't actually contain helm/K8s relevant information. Per @dbkegley , https://docs.posit.co/connect/admin/appendix/off-host/helm-reference/ is a better link to include here"

Updated the link, and cleaned up some old rebranding on the page (RStudio -> Posit)

dbkegley commented 5 months ago

@annikakrilov sorry, I forgot how this all worked 🤦‍♂️ . That section of the README is generated from the default values.yaml. You can update the link here: https://github.com/rstudio/helm/blob/1b339d50c11da0ab0d68c4323d1f8b46740c414f/charts/rstudio-connect/values.yaml#L315-L316

dbkegley commented 5 months ago

I merged this without bumping the chart version because it only contains branding changes in the comments in the values file which is used to generate the docs. I don't think this warrants a new chart release but CI doesn't like it. These comment changes will get picked up during the next Connect chart release.