rstudio / helm

Helm Resources for RStudio Products
MIT License
30 stars 27 forks source link

Connect: Enable Quarto and Python by default for local execution #487

Closed dbkegley closed 2 months ago

dbkegley commented 2 months ago

This PR enables Quarto and Python by default for local execution. They were already enabled by default for off-host execution. This change will happen in the original PR instead. This PR only add the new GHA

Adds a new GHA test that runs on every PR which validates that the local defaults defined in the values are actually installed on the default image:

Related to https://github.com/rstudio/helm/pull/486#issuecomment-2085390506

dbkegley commented 2 months ago

Something that I found confusing: There is also charts/rstudio-connect/Makefile. Some product-specific targets are in the Justfile and others are within the various Makefile.

I didn't even notice that... @colearendt any preference on what lives in the main justfile vs the product-specific makefiles? I can move this target elsewhere if we prefer.

Also, @aronatkins are you okay if I go ahead and enable quarto/python by default in this branch? I'll go ahead and update the NEWS as well.

aronatkins commented 2 months ago

OK enabling, yes.