search

rstudio / helm

Helm Resources for RStudio Products
MIT License
36 stars 28 forks source link

Use the full PWB version docker tag #491

Open cm421 opened 6 months ago

cm421 commented 6 months ago

The tag for PWB image rstudio/rstudio-workbench:ubuntu2204-2024.04.0 doesn't exist on docker hub for some reason, which causes problems because that's the tag used in PWB's helm chart.

While platform team investigates why that tag wasn't created, we can use rstudio/rstudio-workbench:ubuntu2204-024.04.0-735.pro3 instead

kfeinauer commented 6 months ago

@cm421 Need to bump the chart version before merge.

tnederlof commented 6 months ago

I think those annotations are only for artifacthub.io, the values in the values.yaml file under image and session.image are what drive the images pulled by default. The chart is set up to take the app version + tagPrefix and pull automatically, to override we would need to set the following two tags with ubuntu2204-2024.04.0-735.pro3:

image.tag https://github.com/rstudio/helm/blob/90bc753151c4bdbb96d16cdaf505ad914f7b7dd4/charts/rstudio-workbench/values.yaml#L141 session.image.tag https://github.com/rstudio/helm/blob/90bc753151c4bdbb96d16cdaf505ad914f7b7dd4/charts/rstudio-workbench/values.yaml#L29

cm421 commented 6 months ago

So changing appVersion: 2024.04.0 to appVersion: 2024.04.0+735.pro3 in charts/rstudio-workbench/Chart.yaml should set the default tag as well?

Anyone with more helm experience know if changing that will affect other areas as well?

tnederlof commented 6 months ago

So changing appVersion: 2024.04.0 to appVersion: 2024.04.0+735.pro3 in charts/rstudio-workbench/Chart.yaml should set the default tag as well?

Anyone with more helm experience know if changing that will affect other areas as well?

It would apply to the image, but it looks like the variable is used in a couple of spots. Since all the helm charts are consistent across products in this area, it would be nice to leave it as is if the image can be corrected on Monday.