search

rstudio / helm

Helm Resources for RStudio Products
MIT License
30 stars 27 forks source link

Can not get PVC automatically deleted on RSC chart uninstall #492

Open helgard88 opened 2 months ago

helgard88 commented 2 months ago

Currently sharedStorage.annotations default value is {"helm.sh/resource-policy":"keep"}. That means that PVC should not be deleted on helm uninstall. We use automated pipeline with Terraform Kitchen for our testing environment that requires automated destroy of an infrastructure. But in case PVC still exists, PV can not be deleted, and the pipeline crashes on destroy stage. I tried to pass both an empty value and {"helm.sh/resource-policy":"delete"} into sharedStorage.annotations but it did not work. The PVC is still there after the RSC chart gets uninstalled. Is it an expected behaviour? Maybe there are some other workarounds to get the PVC automatically deleted?

tnederlof commented 2 months ago

@helgard88 when you set sharedStorage.annotations, did you remove your current deployment and delete the PVC before trying again? Does the annotation show up as expected when you check describe on the new PVC but the behavior is not what you expect or does the annotation not show up as changed at all?

helgard88 commented 2 months ago

@tnederlof thanks for a response. I tried it on a clean setup and entirely new cluster. The annotation shows up as expected in a PVC, but it still does not get deleted after I uninstall the RSC chart.