search

rstudio / helm

Helm Resources for RStudio Products
MIT License
36 stars 28 forks source link

[PM] Fix deployment strategy #508

Closed calebAtIspot closed 6 months ago

calebAtIspot commented 6 months ago

fixes https://github.com/rstudio/helm/issues/424

It also fixes a bug where ArgoCD is unable to update the deployment when the strategy type is recreate. 

error when patching "/dev/shm/2215103101": Deployment.apps "rstudio-packagemanager-rstudio-pm" is invalid: 

spec.strategy.rollingUpdate: Forbidden: may not be specified when strategy `type` is 'Recreate'
CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

calebAtIspot commented 6 months ago

Also if you're wondering why I don't just pass in null for the rollingUpdate value when I call the chart, it's because of https://github.com/helm/helm/issues/12637

tnederlof commented 6 months ago

Thank you @calebAtIspot I went through the changes and think they make sense as this would bring PPM inline with Workbench and Connect's charts and the default values are for RollingUpdate so the desired default should still work. @atheriel