search

rstudio / helm

Helm Resources for RStudio Products
MIT License
30 stars 27 forks source link

enable the new prometheus endpoint for Connect #516

Closed colearendt closed 1 month ago

colearendt commented 1 month ago

Add a new .prometheus.enabled flag (defaults true) and a .legacyPrometheus flag (defaults false) to revert to old behavior. A simple legacyPrometheus=true should revert back to backwards-compatible behavior, but we want folks to switch to the new endpoint, so that is the new default!

Also removed the default / graphite values from the values.yaml file for simplicity. As per usual, settings that a user sets in our .Values.config will take precedence over convenience helpers like prometheus.port

tnederlof commented 2 weeks ago

@jspiewak and @colearendt should we do something similar for Workbench?

jspiewak commented 2 weeks ago

@tnederlof that would be nice