rstudio / helm

Helm Resources for RStudio Products
MIT License
36 stars 28 forks source link

Enable the new prometheus endpoint for Workbench #532

Closed tnederlof closed 4 months ago

tnederlof commented 4 months ago

This PR follows closely what @colearendt did for Connect here: https://github.com/rstudio/helm/pull/516 Closes: https://github.com/rstudio/helm/issues/490

Add a new .prometheus.enabled flag (defaults true) and a .legacyPrometheus flag (defaults false) to revert to old behavior. A simple legacyPrometheus=true should revert back to backwards-compatible behavior, but we want folks to switch to the new endpoint, so that is the new default!

Also removed the default / graphite values from the values.yaml file for simplicity. As per usual, settings that a user sets in our .Values.config will take precedence over convenience helpers like prometheus.port