rstudio / helm

Helm Resources for RStudio Products
MIT License
36 stars 28 forks source link

Update docs for Package Manager Postgres.UsageDataPassword bug #564

Closed glin closed 1 month ago

glin commented 1 month ago

Same as #562, redoing for CI issue where checks pass but aren't being reported to PR correctly, preventing the merge

Postgres.UsageDataPassword is supposed to default to Postgres.Password, but a bug in recent PPM versions prevents this from working. So as a temporary workaround, the Postgres.UsageDataPassword setting must be explicitly set to Postgres.Password when using Postgres with usage data enabled.

This will be fixed in the next Package Manager release. The config can be removed after the next release, but it also won't cause any issues if you keep it around for the next release.

glin commented 1 month ago

@tylfin Are you able to force merge this? All the checks pass but the status is not reported back to the PR.

I'm not sure if this happens for all PRs or just this branch. I did notice an install error in the test workflow that doesn't cause the check to fail, but could be related? I see it on multiple PRs though, and not just for changes to the PPM chart.

Installing chart 'rstudio-pm => (version: "0.5.36", path: "charts/rstudio-pm")'...
Installing chart with values file 'charts/rstudio-pm/ci/all-values.yaml'...
Creating namespace 'rstudio-pm-v8o1cqhvrw'...
namespace/rstudio-pm-v8o1cqhvrw created
Error: timed out waiting for the condition
========================================================================================================================
........................................................................................................................
==> Events of namespace rstudio-pm-v8o1cqhvrw
........................................................................................................................
LAST SEEN   TYPE      REASON              OBJECT                                       SUBOBJECT   SOURCE                  MESSAGE                                                                                                              FIRST SEEN   COUNT   NAME
2m17s       Warning   FailedCreate        replicaset/rstudio-pm-v8o1cqhvrw-5864559f9               replicaset-controller   Error creating: pods "rstudio-pm-v8o1cqhvrw-5864559f9-" is forbidden: no PriorityClass with name someval was found   5m           16      rstudio-pm-v8o1cqhvrw-5864559f9.17faab600a696fb2
15s         Normal    NoPods              poddisruptionbudget/rstudio-pm-v8o1cqhvrw                controllermanager       No matching pods found                                                                                               5m1s         12      rstudio-pm-v8o1cqhvrw.17faab600815[23](https://github.com/rstudio/helm/actions/runs/11146470819/job/30978500456#step:8:24)0f
5m          Normal    ScalingReplicaSet   deployment/rstudio-pm-v8o1cqhvrw                         deployment-controller   Scaled up replica set rstudio-pm-v8o1cqhvrw-5864559f9 to 1                                                           5m           1       rstudio-pm-v8o1cqhvrw.17faab600a3[31](https://github.com/rstudio/helm/actions/runs/11146470819/job/30978500456#step:8:32)9c1
........................................................................................................................
<== Events of namespace rstudio-pm-v8o1cqhvrw
........................................................................................................................
========================================================================================================================
Deleting release 'rstudio-pm-v8o1cqhvrw'...
These resources were kept due to the resource policy:
[PersistentVolumeClaim] rstudio-pm-v8o1cqhvrw-shared-storage
release "rstudio-pm-v8o1cqhvrw" uninstalled
Deleting namespace 'rstudio-pm-v8o1cqhvrw'...
namespace "rstudio-pm-v8o1cqhvrw" deleted
Error: Error installing charts: Error processing charts
Namespace 'rstudio-pm-v8o1cqhvrw' terminated.
------------------------------------------------------------------------------------------------------------------------
 ✖︎ rstudio-pm => (version: "0.5.[36](https://github.com/rstudio/helm/actions/runs/11146470819/job/30978500456#step:8:37)", path: "charts/rstudio-pm") > Error waiting for process: exit status 1
------------------------------------------------------------------------------------------------------------------------
Error installing charts: Error processing charts
Error: Process completed with exit code 1.

https://github.com/rstudio/helm/actions/runs/11146470819