search

rstudio / helm

Helm Resources for RStudio Products
MIT License
36 stars 28 forks source link

Re-enable chart install tests, but exclude all currently failing charts #581

Closed jforest closed 1 month ago

jforest commented 1 month ago

Marking this as ready to review for feedback on the idea.

The current set of values files in the ci subdirectory of the charts are fine for linting, but many values are nonsense and end up causing installs to fail.

My idea is that we make an entirely new set of values files that are just for installs (they should pass linting anyway right?) while keeping the existing values files. The one change will be to rename all the current values files to lint-<existingname>.yaml so they get deleted in a step of the install workflow before the ct install tests run

jforest commented 1 month ago

After talking with @jspiewak I'm going to close this PR, and open a new one where I will move the current ci directory to ci-lint and create a new ci-install directory within which I will create install test values files.

Then I will need to modify the workflows to symlink the proper one in place before running lints or installs. (and clean up after themselves when done). Also will need to adjust the Justfile to do the right thing.