Add a few more unittests for rstudio-workbench

rstudio / helm

Helm Resources for RStudio Products

MIT License

36 stars 28 forks source link

Add a few more unittests for rstudio-workbench #615

Closed jforest closed 2 days ago

jforest commented 6 days ago

@zachhannum @nathanchilton I am including you both here as you were tapped by Maria and Jason respectively to be helping out with the helm chart unittesting/install testing work.

jforest commented 3 days ago

LGTM. I'm assuming that the Legacy Port values are not configurable and that they're always going to 9108.

Exactly! https://github.com/rstudio/helm/blob/23dbd10778f0c4f9ae77e31ee9a391efcdcd8ef9/charts/rstudio-workbench/templates/svc.yaml#L31-L38