Closed gadenbuie closed 3 years ago
Can you add some unit tests?
I think the failing checks were just unlucky; they didn't make it past the setup step on macOS. I can't re-run the jobs but I suspect the checks would pass if someone were to do that for me. 😇
Checks pass. @wch , Ok to merge?
Fixes #243
Offered as a possible solution to #243. Rather than adding a global option to control
.noWS
, this suggestion adds.noWS
towithTags()
, using the sketch from @wch in https://github.com/rstudio/htmltools/issues/243#issuecomment-833102373.If
.noWS
isn't set,withTags()
works as before.But setting
.noWS
onwithTags()
sets the whitespace option for all tags in thewithTags()
call.You can still set
.noWS
on individual tags to override the whitespace option for an individual tag.If this seems like a reasonable approach, I can follow up with additional tests.