Fix bug in `tagQuery()`'s `$remove()`, `$after()`, `$before()`, `$replaceWith()`

rstudio / htmltools

Tools for HTML generation and output

https://rstudio.github.io/htmltools/

214 stars 67 forks source link

Fix bug in `tagQuery()`'s `$remove()`, `$after()`, `$before()`, `$replaceWith()` #348

Closed schloerke closed 1 year ago

schloerke commented 1 year ago

Fixes #346

tagQuery()'s $remove(), $after(), $before(), $replaceWith() had a bug that prevented expected behavior when sibling children values where not tag elements.

Other changes:

~~Removed elements are now completely removed from the $children attr. (Not just replaced with NULL which is processed like a no-op.)~~

schloerke commented 1 year ago

the macOS / windows failures are due to GHA installation of R error unrelated to this PR