rstudio / htmltools

Tools for HTML generation and output
https://rstudio.github.io/htmltools/
214 stars 67 forks source link

CSS selection rules should include hyphens and underscores #354

Closed slodge closed 1 year ago

slodge commented 1 year ago

Fixes #355

Extend the current regexes to allow selections of examples like:

These are valid identifiers based on https://www.w3.org/TR/CSS21/syndata.html#value-def-identifier

Todo:

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: slodge
:white_check_mark: schloerke
:x: Stuart Lodge


Stuart Lodge seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

slodge commented 1 year ago
+ 6323da93a22f171f2810657ea07b29aaaa44de80 `devtools::document()` (GitHub Actions)
Error: Some auto-generated commits were found. GHA is not allowed to push commits back to a forked repo.
Error: Please perform and commit these actions manually. It may help to merge in the latest changes from the base branch.
Error: Process completed with exit code 1.

Saw this error... have pushed some changes - but they're nothing to do with this commit...

Personally I'm very happy with GitHub Actions running document instead of developers - sounds like a perfect place for automation to reduce work rather than adding to it :)

(insert post-xmas back-at-work fat and grumpy Stuart emoji here)

schloerke commented 1 year ago

GHA routine issue is unrelated to this PR