search

rstudio / htmltools

Tools for HTML generation and output
https://rstudio.github.io/htmltools/
214 stars 67 forks source link

Avoid testing messages generated in rlang #367

Closed lionel- closed 1 year ago

lionel- commented 1 year ago

The error message in case of empty arguments has changed slightly in the next version of rlang that is about to be sent to CRAN. This causes some tests in htmltools to fail because they check the exact content of error messages generated in a third party package. To avoid this, I changed the expectations to error snapshots.

cpsievert commented 1 year ago

Thanks @lionel-. I think we'd prefer to still run these tests on CRAN (and in a way that isn't restricting the rlang version), so I'll close this in preference of #368

lionel- commented 1 year ago

Note that the expect_error() inside the snapshot does run on CRAN, it's just the contents of the messages that are not checked on CRAN. I agree that the dependency on the rlang version is not ideal, I suggested an alternative in #368.