Closed cpsievert closed 1 year ago
After investigating this and discussing with Carson, we think the best approach is to add
.html-fill-container > :not(.html-fill-item) {
flex: 0 0 auto;
}
The flex: 0 0 auto
changes the default flex behavior of a non-fill item so that it won't grow or shrink in the display: flex
context of a fillable container. This ensures that non-fill items with a set height behave consistently inside and outside a fillable container.
Edit: It turns out the min-height: 0
isn't required because flex-shrink
is 0
.
For example, both
#inner
and#inner2
shrink to a size of150px
(since the default value offlex-shrink
is 1, not 0). Based on our currentfill
semantics, that's probably surprising behavior.We could/should probably fix this by adding something like this to
inst/fill/fill.css