Closed gadenbuie closed 1 year ago
@schloerke I added skip_if_not_installed("knitr")
to the test I added around this change, should we ensure knitr is installed in CI for r-cmd-check
? It currently isn't due to knitr being an Enhances dependency
Good catch!
Yes, let's add it in Config/needs/check: knitr
in the DESCRIPTION file. (Similar to Config/needs/website
)
This PR fixes #375, making it possible to include an
htmlDependency()
simply by calling it in an R chunk where it's handled byknit_print()
.Previously, users had to include the dependency in a
tagList()
or atag
to use theknit_print.shiny.tag
method. Fortunately, that same method works forhtmlDependency()
objects too.This small R Markdown document will now show the pencil icon, where previously it would print the font awesome dependency and no icon would be visible.