Closed gadenbuie closed 1 year ago
Thanks for the input, I'm going to move this to draft while I consider next steps.
@cpsievert @schloerke I updated this PR to reduce the scope and address the immediate problem posed in #124. With this change, includeHTML()
will issue a warning if it detects that the user is attempting to include a complete HTML document.
I've opened a new issue #383 to track thoughts and progress toward a new includeHTMLDocument()
function, which uses the implementation I've removed from this PR.
Looks good -- just needs a NEWS entry.
Fixes #124 by emitting a warning when
includeHTML()
is passed a path to a file containing a complete HTML document.This PR originally contained an implementation of
includeHTMLDocument()
. I'll open a new issue to track progress on that front, but I didn't want to hold up this change on working out the details we'd need to address there.Example
includeHTML()
now warns with a recommendation to useincludeHTMLDocument()