search

rstudio / htmltools

Tools for HTML generation and output
https://rstudio.github.io/htmltools/
215 stars 68 forks source link

Object generated by `htmltools::htmlDependency` fails `rmarkdown::validate_html_dependency` #6

Open lianos opened 10 years ago

lianos commented 10 years ago

The list element that is meant to hold the name of the directory to find "the goods" in seems to be in flux and the object that is generated within htmltools is not valid as far as rmarkdown is concerned.

htmltools::htmlDependency puts this in a list element named src and it seems that rmarkdown::validate_html_dependency expects this to be in a list element named path.

Furthermore, src is flagged as an invalid_field at the tail end rmarkdown::validate_html_dependency.

I'm running into this bug because I'm trying to get an rmdexmaples::datatable into an rmarkdown report.

jjallaire commented 10 years ago

I think this is due to the fact that htmltools is temporarily incompatible with rmarkdown (as we are waiting for some changes to htmltools to hit CRAN before merging dependent changes into rmarkdown). I think if you install the htmltools-refactor branch of rmarkdown (https://github.com/rstudio/rmarkdown/tree/htmltools-refactor) things will work as expected. @jcheng5 can tell us for sure.

lianos commented 10 years ago

Thanks for the quick response!

Installing the htmltools-refactor branch of rmarkdown has resolved this issue for me.

I'd close this, but perhaps it's worth leaving this issue open until this is sorted out in master just in case others get bit by this in the interim ... your call.

Thanks again!